extract attribute from properties function #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
force-pushed
the
fix_properties
branch
2 times, most recently
from
fa54c1a
to
3a0bfd0
Compare
nevermore3
force-pushed
the
fix_properties
branch
2 times, most recently
from
412d209
to
8249700
Compare
Codecov Report
@@ Coverage Diff @@
## master #4604 +/- ##
==========================================
+ Coverage 84.66% 84.70% +0.04%
==========================================
Files 1357 1357
Lines 135081 135372 +291
==========================================
+ Hits 114360 114667 +307
+ Misses 20721 20705 -16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Add tests? |
jievince
reviewed
Sep 5, 2022
nevermore3
force-pushed
the
fix_properties
branch
from
d549777
to
86eae2a
Compare
nevermore3
force-pushed
the
fix_properties
branch
from
86eae2a
to
b5e571b
Compare
jievince
reviewed
Sep 6, 2022
| // match (v) return properties(v).name | ||
| auto *inputPropExpr = static_cast<InputPropertyExpression *>(argExpr); | ||
| auto &aliasName = inputPropExpr->prop(); | ||
| propsUsed_.insertVertexProp(aliasName, unKnowType_, propName); |
There was a problem hiding this comment.
How to know v is a vertex or edge?
There was a problem hiding this comment.
edge is only subscriptExpression or listComprehensionExpression, can be distinguished by the expression type
There was a problem hiding this comment.
Is it invalid to use properties(edge).name?
There was a problem hiding this comment.
parser error in cypher, ok in ngql
jievince
approved these changes
Sep 6, 2022
Shylock-Hg
approved these changes
Sep 6, 2022
Sophie-Xie
pushed a commit
that referenced
this pull request
Sep 8, 2022
* extract attribute from properties function * fix error * fix subscript error * add test case * process scanEdges * fix test error
Sophie-Xie
added a commit
that referenced
this pull request
Sep 13, 2022
* fix lookup (#4552) fix Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix split brain in raft (#4479) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix invalid filter in GetProp make storage crashed (#4568) Co-authored-by: haowen <19355821+wenhaocs@users.noreply.github.com> * fix scan vertex/edge do not handle ttl (#4578) * fix scan vertex/edge do not handle ttl * use ErrorCode to unify community version and end version * Fix #1212. Return FoldConstantExprVisitor, if status_ already failed due to found syantax errors. (#4607) Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> * Avoid fatal when expression illegal. (#4618) * Fix concurrent exception related to multi-match statement (#4605) * fix filter executor * Fix concurrency exception of multi-match statements fix iterator fix small delete small delete skip iterator type handle for concurrency small delete fix scan edges small delete small delete fix small delete small change small change fix ut small fix Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Prune properties(#4523) * fix conflict * extract attribute from properties function (#4604) * extract attribute from properties function * fix error * fix subscript error * add test case * process scanEdges * fix test error * add unwind & check vidType when executing not validate (#4456) * Update AppendVerticesExecutor.cpp fix conflict * Update AppendVerticesExecutor.cpp * Replace obsolete RocksDB API (#4395) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Update PrunePropertiesRule.feature * remove useless dc (#4533) * Update PrunePropertiesRule.feature * fix test error Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: haowen <19355821+wenhaocs@users.noreply.github.com> Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com> Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com> Co-authored-by: Qiaolin Yu <90088090+Qiaolin-Yu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close https://github.com/vesoft-inc/nebula-ent/issues/1157
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: